-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage: Remove support for NVDIMM namespaces #5353
storage: Remove support for NVDIMM namespaces #5353
Conversation
92ab31c
to
4aefc02
Compare
@vojtechtrefny I am able to select a NVDIMM device in the fsdax mode for the installation. It just won't boot. I guess that is the expected behaviour, right? I have used the Blivet changes as well for testing. |
Yes, device mapper doesn't work with the fsdax mode (only with the sector mode). I'd say this is expected and we should just ignore it. |
We could add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, but I didn't stop to think what might be missing...
c0fcd70
to
ebb40fb
Compare
Done. |
All additional support for NVDIMM is being deprecated and removed, especially the support for the namespace reconfiguration. However, namespaces configured in the block/storage mode can be still used for installation. The `nvdimm` kickstart command is deprecated and will be removed in future releases. Resolves: #INSTALLER-3766
Don't allow to select devices that cannot be used for the installation. For example, NVDIMM in the fsdax mode prevents the system from booting.
ebb40fb
to
5da3b57
Compare
/kickstart-test --testtype smoke |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
All additional support for NVDIMM is being deprecated and removed, especially the support for the namespace reconfiguration. However, namespaces configured in the block/storage mode can be still used for installation.
The
nvdimm
kickstart command is deprecated and will be removed in future releases.Depends on: pykickstart/pykickstart#469
Blocks: storaged-project/blivet#1172
Resolves: #INSTALLER-3766